[LinkV1] Remove text from Link a11y tree and add a11yLabel #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dewsk
approved these changes
Feb 10, 2025
rurikoaraki
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Previously, we were including the Text component in non-inline links as part of the accessibilty tree. This is unnecessary and results in duplicate narration of the link text when using Narrator in scan mode (no duplicate narration with VO but the extra text element in the a11y tree is still unnecessary).
Additionally, we're not setting the link text as the accessibilityLabel of the link on win32 so I fixed that as well.
Before:
win32
macOS
After:
win32
macOS
Verification
Tested narration of link with Narrator in scan mode on win32 and with VO on macOS.
Pull request checklist
This PR has considered (when applicable):